Skip to content

AJ#1659

Closed
ajaitech wants to merge 2 commits intoreact-native-community:mainfrom
ajaitech:main
Closed

AJ#1659
ajaitech wants to merge 2 commits intoreact-native-community:mainfrom
ajaitech:main

Conversation

@ajaitech
Copy link
Copy Markdown

No description provided.

@Simek
Copy link
Copy Markdown
Member

Simek commented Jul 6, 2025

Hey @ajaitech, thanks for attempting to add new entries, but this PR performs way more changes and additions than necessary, few highlights:

  • we use scripts to format the entry list and applied formatting changes does not match the script output, so they will be reverted on the next run of it automatically
  • expo-facebook is deprecated for few years in favor of expo-auth-session, and its source has been removed from expo/expo repository, hence it's not a valid entry anymore
  • some of new entries you have propose are devDependencies, and if expo or expo-doctor warn you about them, it most likely means that they are listed in wrong dependency group in your project's package.json

Due to that, I'm going to close this PR for now, but feel free to follow up with set of new PR, one for each new entry, so it's easier to review them, and provide necessary feedback. 🙂

@Simek Simek closed this Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants